-
Notifications
You must be signed in to change notification settings - Fork 135
feat(pt): add scaffolding for Portuguese and #357
translation
#2357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d2d1bd2
to
9da018b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, this looks like a good translation.
just a few minor nits.
I'm a bit unsure about translating certain context-specific terms like witness. might be worth discussing whether they should stay as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool initiative!
I think most other translations only translate the newsletter, and you might find that translating the topic pages is a big additional burden, so perhaps you would want to first aim for a smaller goal and then expand later if you find you have the energy for it.
I think it's better to keep it as-is as it's used as a technical term. |
For the German translation, we have a file to collate decisions on which terms are not translated and how terms are translated to be consistent across different newsletters. Something like that might also work well for you. |
@murchandamus I created an initial portuguese version to but I'm failing to push it to this repo. |
maybe this PR should be broken in two so that other people can start to contribute with translations with initial configuration to Portuguese already in place. |
True, I just replicated the english scaffolding. I'll remove it for now, if someone wants to translate that they can add it later. |
41cbae5
to
44c15e9
Compare
44c15e9
to
5cfe4a2
Compare
Why would we do that? When this gets merged you can build on top of this PR. |
Usually it's one feature for PR and how long it would take to this PR to be merged |
No description provided.